Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neptune): add engine version 1.1.0.0 and instance types t4g, r6g #17669

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

jumic
Copy link
Contributor

@jumic jumic commented Nov 23, 2021

Add new instance types general-purpose T4g and memory-optimized R6g (see announcement). The specific instance types were copied from the pricing page.

Add new Neptune engine version 1.1.0.0 which was part of the announcement, too.

Deployment tested successfully in region us-east-1:

new neptune.DatabaseCluster(this, 'Database', {
  vpc,
  instanceType: neptune.InstanceType.T4G_MEDIUM,
  engineVersion: neptune.EngineVersion.V1_1_0_0,
});

new neptune.DatabaseCluster(this, 'Database2', {
  vpc,
  instanceType: neptune.InstanceType.R6G_LARGE,
  engineVersion: neptune.EngineVersion.V1_1_0_0,
});

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 23, 2021

@github-actions github-actions bot added the @aws-cdk/aws-neptune Related Amazon Neptune label Nov 23, 2021
@pahud
Copy link
Contributor

pahud commented Nov 24, 2021

Hi @zxkane are you interested to take a look as an initial review? Please leave a review comment with "LGTM" if you think it's good with you.

Thanks.

@zxkane
Copy link
Contributor

zxkane commented Nov 24, 2021

LGTM

@njlynch njlynch added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Nov 30, 2021
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify
Copy link
Contributor

mergify bot commented Nov 30, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 566d777
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 83e669d into aws:master Nov 30, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 30, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

pedrosola pushed a commit to pedrosola/aws-cdk that referenced this pull request Dec 1, 2021
…aws#17669)

Add new instance types general-purpose T4g and memory-optimized R6g (see [announcement](https://aws.amazon.com/about-aws/whats-new/2021/11/aws-graviton2-based-instances-amazon-neptune/)). The specific instance types were copied from the [pricing page](https://aws.amazon.com/de/neptune/pricing/).

Add new Neptune engine version 1.1.0.0 which was part of the announcement, too.

Deployment tested successfully in region us-east-1:

```ts
new neptune.DatabaseCluster(this, 'Database', {
  vpc,
  instanceType: neptune.InstanceType.T4G_MEDIUM,
  engineVersion: neptune.EngineVersion.V1_1_0_0,
});

new neptune.DatabaseCluster(this, 'Database2', {
  vpc,
  instanceType: neptune.InstanceType.R6G_LARGE,
  engineVersion: neptune.EngineVersion.V1_1_0_0,
});
```


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…aws#17669)

Add new instance types general-purpose T4g and memory-optimized R6g (see [announcement](https://aws.amazon.com/about-aws/whats-new/2021/11/aws-graviton2-based-instances-amazon-neptune/)). The specific instance types were copied from the [pricing page](https://aws.amazon.com/de/neptune/pricing/).

Add new Neptune engine version 1.1.0.0 which was part of the announcement, too.

Deployment tested successfully in region us-east-1:

```ts
new neptune.DatabaseCluster(this, 'Database', {
  vpc,
  instanceType: neptune.InstanceType.T4G_MEDIUM,
  engineVersion: neptune.EngineVersion.V1_1_0_0,
});

new neptune.DatabaseCluster(this, 'Database2', {
  vpc,
  instanceType: neptune.InstanceType.R6G_LARGE,
  engineVersion: neptune.EngineVersion.V1_1_0_0,
});
```


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-neptune Related Amazon Neptune pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants