Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): bundling skipped with --exclusively option and stacks under stage #17210

Merged
merged 4 commits into from
Nov 24, 2021
Merged

fix(core): bundling skipped with --exclusively option and stacks under stage #17210

merged 4 commits into from
Nov 24, 2021

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Oct 28, 2021 •
edited
Loading

We were comparing bundling stacks of the form Stage/Stack with stack
names of the form Stage-Stack.

For stacks with NodejsFunctions this leads to assets containing the whole CDK project because
when bundling is skipped the asset references the source directory which is the project root.

Closes #12898
Closes #15346

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jogold
fix(core): bundling skipped with --exclusively option and stacks unde…
a7641b5 
…r stage

We were comparing bundling stacks of the form `Stage/Stack` with stack
names of the form `Stage-Stack`.

Closes aws#12898
Closes aws#15346
@gitpod-io
Copy link

gitpod-io bot commented Oct 28, 2021

@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Oct 28, 2021
@jogold jogold mentioned this pull request Oct 28, 2021
Closed
@mergify
Copy link
Contributor

mergify bot commented Nov 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: dfb44b8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit cda6601 into aws:master Nov 24, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@moltar
Copy link
Contributor

moltar commented Nov 24, 2021

@jogold you are my hero! Thank you 🙏 we've been pained by this way too long.

@slaskowski-transactionlink
Copy link

slaskowski-transactionlink commented Nov 25, 2021 •
edited
Loading

@jogold What i case of glob patterns like */Stack1? It will not work. Also for custom stack names it will be even worse and can break **/* deploys if im right

@slaskowski-transactionlink
Copy link

Ive resolved it locally for once and the issue is that we take stackName prop instead of the logical path of stack hence the issue. Please reconsider this solution

@jogold jogold deleted the bundling-excl-stage branch November 25, 2021 16:16
@jogold
Copy link
Contributor Author

jogold commented Nov 25, 2021

@slaskowski-transactionlink can you open an issue once this is released with the next version if you still experience problems?

@slaskowski-transactionlink
Copy link

@jogold cant we just reopen #12898 since its not fixed?

@jogold
Copy link
Contributor Author

jogold commented Nov 25, 2021

@jogold cant we just reopen #12898 since its not fixed?

I can't reopen issues (no write access to this repo)

How did you test */Stack1 with the fix from this PR?

@slaskowski-transactionlink
Copy link

@jogold ok i created new issue see #17717

@jogold jogold mentioned this pull request Nov 25, 2021
Closed
beezly pushed a commit to beezly/aws-cdk that referenced this pull request Nov 29, 2021
@jogold
fix(core): bundling skipped with --exclusively option and stacks unde…
aa287e6 
…r stage (aws#17210)

We were comparing bundling stacks of the form `Stage/Stack` with stack
names of the form `Stage-Stack`.

For stacks with `NodejsFunction`s this leads to assets containing the whole CDK project because
when bundling is skipped the asset references the source directory which is the project root.

Closes aws#12898
Closes aws#15346


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@joel-aws joel-aws mentioned this pull request Dec 1, 2021
Open
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@jogold @TikiTDO
fix(core): bundling skipped with --exclusively option and stacks unde…
39d5fa0 
…r stage (aws#17210)

We were comparing bundling stacks of the form `Stage/Stack` with stack
names of the form `Stage-Stack`.

For stacks with `NodejsFunction`s this leads to assets containing the whole CDK project because
when bundling is skipped the asset references the source directory which is the project root.

Closes aws#12898
Closes aws#15346


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@corymhall corymhall mentioned this pull request Jul 18, 2022
Closed
@rv2673 rv2673 mentioned this pull request Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/core Related to core CDK functionality
Projects
None yet
Milestone
No milestone
5 participants
@jogold @aws-cdk-automation @moltar @slaskowski-transactionlink @rix0rrr