Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: feat(assertions): an initial version of the CDK 'assert' #15163

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

MrArnoldPalmer
Copy link
Contributor

revert: feat(assertions): an initial version of the CDK 'assert' library, now experimentally available in all supported languages (#14952)

This breaks the ubergen cli integ tests with the following:

Error: Cannot find module '@aws-cdk/cloudformation-diff'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/tmp/cdk-uber-cfn-include-09us6v40o6nf/node_modules/monocdk/lib/assertions/lib/vendored/assert/assertions/match-template.js:4:17)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
Subprocess exited with error 1
Error: Subprocess exited with error 1
    at ChildProcess.proc.on.code (/tmp/cdk-rundist/node_modules/aws-cdk/lib/api/cxapp/exec.ts:122:23)
    at ChildProcess.emit (events.js:198:13)
    at ChildProcess.EventEmitter.emit (domain.js:448:20)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12)
FAIL ./uberpackage.integtest.js (10.785 s)
  uberpackage
    ✕ works with cloudformation-include (9950 ms)

Refs: a23aa63


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…ary, now experimentally available in all supported languages (#14952)

Refs: a23aa63
@MrArnoldPalmer MrArnoldPalmer requested a review from skinny85 June 16, 2021 22:37
@gitpod-io
Copy link

gitpod-io bot commented Jun 16, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 16, 2021
@MrArnoldPalmer MrArnoldPalmer added pr/no-squash This PR should be merged instead of squash-merging it pr/do-not-merge This PR should not be merged at this time. labels Jun 16, 2021
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with the original (#14952), looks good.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 081c6a7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@MrArnoldPalmer MrArnoldPalmer merged commit c647e38 into release Jun 16, 2021
@MrArnoldPalmer MrArnoldPalmer deleted the chore/revert-assertions branch June 16, 2021 23:39
matthewsvu pushed a commit to matthewsvu/aws-cdk that referenced this pull request Jun 22, 2021
…ary, now experimentally available in all supported languages (aws#14952) (aws#15163)

Refs: a23aa63
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…ary, now experimentally available in all supported languages (aws#14952) (aws#15163)

Refs: a23aa63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr/do-not-merge This PR should not be merged at this time. pr/no-squash This PR should be merged instead of squash-merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants