Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codecommit): take the region and account of an imported Repository from its ARN #13066

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

skinny85
Copy link
Contributor

To align it with how other resources work, for example
S3 Buckets.

Fixes #13025


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 requested a review from a team February 15, 2021 23:40
@skinny85 skinny85 self-assigned this Feb 15, 2021
@gitpod-io
Copy link

gitpod-io bot commented Feb 15, 2021

@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 8a91d48
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5f0ee88 into aws:master Feb 16, 2021
@skinny85 skinny85 deleted the fix/codecommit-repo-region-from-arn branch February 16, 2021 18:36
NovakGu pushed a commit to NovakGu/aws-cdk that referenced this pull request Feb 18, 2021
…y from its ARN (aws#13066)

To align it with how other resources work, for example
[S3 Buckets](https://github.com/aws/aws-cdk/blob/c6256992902fc4237ceb9f965e970e2c2ef00777/packages/%40aws-cdk/aws-s3/lib/bucket.ts#L1285-L1286). 

Fixes aws#13025

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb pushed a commit that referenced this pull request Feb 22, 2021
…y from its ARN (#13066)

To align it with how other resources work, for example
[S3 Buckets](https://github.com/aws/aws-cdk/blob/c6256992902fc4237ceb9f965e970e2c2ef00777/packages/%40aws-cdk/aws-s3/lib/bucket.ts#L1285-L1286). 

Fixes #13025

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codecommit Related to AWS CodeCommit contribution/core This is a PR that came from AWS.
Projects
None yet
3 participants