fix(ecs-patterns): remove default value for desiredCount #12992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
piradeepk
changed the title
piradeepk
added
@aws-cdk/aws-ecs-patterns
piradeepk
force-pushed
the
master
branch
2 times, most recently
from
095bc2b to
4864241
Compare
piradeepk
force-pushed
the
master
branch
3 times, most recently
from
e823047 to
1193435
Compare
piradeepk
force-pushed
the
master
branch
3 times, most recently
from
f1f4f10 to
1af07cb
Compare
SoManyHs
suggested changes
Feb 17, 2021
packages/@aws-cdk/aws-ecs-patterns/lib/base/network-multiple-target-groups-service-base.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-ecs-patterns/lib/base/queue-processing-service-base.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-ecs-patterns/lib/base/application-load-balanced-service-base.ts
Show resolved
Hide resolved
piradeepk
force-pushed
the
master
branch
2 times, most recently
from
d717017 to
a625cd5
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
SoManyHs
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the default desired count set for each service by the CDK.
CloudFormation now allows the desired count to be undefined, to maintain a services existing desired count when updating an ECS service aws/containers-roadmap#493 (comment)
Fixes #12990.