Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(lambda): recommend NODEJS_12_X instead of NODEJS_10_X #12713

Merged
merged 3 commits into from
Feb 1, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 26, 2021

This PR recommends NODEJS_12_X instead of NODEJS_10_X for deprecated versions of lambda.Runtime

Screenshot

Screen Shot 2021-01-26 at 11 10 05 AM

Reasons for recommending NODEJS_12_X:

  • Node.js 12.x went LTS in October 2019, and has been actively supported till October 2020.
  • Node.js 10.x is going end-of-life on April 30th, 2021

https://endoflife.date/nodejs


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 26, 2021

@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Jan 26, 2021
@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a5fb0c6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 898acfe into aws:master Feb 1, 2021
@trivikr trivikr deleted the recommend-NODEJS_12_X branch February 1, 2021 16:12
NovakGu pushed a commit to NovakGu/aws-cdk that referenced this pull request Feb 18, 2021
This PR recommends NODEJS_12_X instead of NODEJS_10_X for deprecated versions of lambda.Runtime

<details>
<summary>Screenshot</summary>

![Screen Shot 2021-01-26 at 11 10 05 AM](https://user-images.githubusercontent.com/16024985/105892863-44109480-5fc7-11eb-9cb2-c91e8e13d9f3.png)

</details>

Reasons for recommending NODEJS_12_X:
* Node.js 12.x went LTS in October 2019, and has been actively supported till October 2020.
* Node.js 10.x is going end-of-life on April 30th, 2021

https://endoflife.date/nodejs

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot pushed a commit that referenced this pull request Feb 23, 2021
Follow-up to #12713
This PR recommends NODEJS_12_X instead of NODEJS_10_X in aws-cdk READMEs.

Reasons for recommending NODEJS_12_X:
* Node.js 10.x is going end-of-life on April 30th, 2021
* Node.js 12.x went LTS in October 2019, and has been actively supported till October 2020.
* Node.js 14.x went LTS in October 2020, and is now actively supported LTS version.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda Related to AWS Lambda
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants