Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore (docs): Replaced tools text w/output from cdk --help v0.17.0 #1207

Merged
merged 2 commits into from
Nov 19, 2018
Merged

chore (docs): Replaced tools text w/output from cdk --help v0.17.0 #1207

merged 2 commits into from
Nov 19, 2018

Conversation

Doug-AWS
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

RomainMuller
RomainMuller approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes me wonder if maybe we shouldn't auto-generate this from the actual output of running the command? So it's always up-to-date...

@Doug-AWS Doug-AWS merged commit 127bb59 into master Nov 19, 2018
@Doug-AWS
Copy link
Contributor Author

Doug-AWS commented Nov 19, 2018 •
edited
Loading

It would be simple to do:

tools.rst includes cdk_help.txt, which we generate by:

echo ".. code-block:: sh" >| cdk_help.txt
echo "" >> cdk_help.txt
cdk --help |  sed 's/^/    /' >> cdk_help.txt

@Doug-AWS Doug-AWS mentioned this pull request Nov 19, 2018
Closed
@Doug-AWS
Copy link
Contributor Author

I tried, but ran into dead ends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Doug-AWS @RomainMuller