chore: Restore @types/node version and upgrade some packages #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@types/node` package was inadvertently upgraded to `^10.x.x` by #692, but our support policy currently allows `^8.11.0` and up. This commit reverts the type definitions to maintain compatibility. Also, while the previous change intended to upgrade dependnecies, `fs-extra`, `@types/fs-extra` and `@types/lodash` were not uniformly upgraded. This change also addresses that.
|
Created #1194 to track introducing a |
rix0rrr
approved these changes
Nov 17, 2018
eladb
approved these changes
Nov 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@types/nodepackage was inadvertently upgraded to^10.x.xby #692, but our support policy currently allows
^8.11.0and up. Thiscommit reverts the type definitions to maintain compatibility.
Also, while the previous change intended to upgrade dependnecies,
fs-extra,@types/fs-extraand@types/lodashwere not uniformlyupgraded. This change also addresses that.