feat(ecs): introduce a new Image type, TagParameterContainerImage, to be used in CodePipeline #11795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
skinny85
changed the title
skinny85
force-pushed
the
feat/pipeline-container-image
branch
from
1b4a2a6 to
ffced5c
Compare
SoManyHs
reviewed
Dec 2, 2020
packages/@aws-cdk/aws-codepipeline-actions/test/integ.pipeline-ecs-separate-source.lit.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-codepipeline-actions/test/integ.pipeline-ecs-separate-source.lit.ts
Outdated
Show resolved
Hide resolved
| * for example in a CodePipeline that pushes a new tag of the image to the repository during a build step, | ||
| * and then provides that new tag through the Parameter in the deploy step. | ||
| * | ||
| * @see #tagParameterName |
There was a problem hiding this comment.
For some reason tagParameterName sounds...kind of weird. Not quite intuitive? But reading the description of what it is I'm not sure I can think of a better name. Maybe ContainerImageTagParameter?
There was a problem hiding this comment.
Sorry, are you commenting on the name of the getter, the name of the class, or both? 😃
packages/@aws-cdk/aws-codepipeline-actions/test/integ.pipeline-ecs-separate-source.lit.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-codepipeline-actions/test/integ.pipeline-ecs-separate-source.lit.ts
Outdated
Show resolved
Hide resolved
SoManyHs
approved these changes
Dec 7, 2020
…ant to be used in CodePipeline While CDK Pipelines is the idiomatic way of deploying ECS applications in CDK, it does not handle the case where the application's source code is kept in a separate source code repository from the CDK infrastructure code. This adds a new class to the ECS module, `TagParameterContainerImage`, that allows deploying a service managed that way through CodePipeline. Related to aws#1237 Related to aws#7746
Co-authored-by: Hsing-Hui Hsu <[email protected]>
…erContainerImage.
skinny85
force-pushed
the
feat/pipeline-container-image
branch
from
fad029d to
3ff478c
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
flochaz
pushed a commit
to flochaz/aws-cdk
that referenced
this pull request
Jan 5, 2021
… be used in CodePipeline (aws#11795) While CDK Pipelines is the idiomatic way of deploying ECS applications in CDK, it does not handle the case where the application's source code is kept in a separate source code repository from the CDK infrastructure code. This adds a new class to the ECS module, `TagParameterContainerImage`, that allows deploying a service managed that way through CodePipeline. Related to aws#1237 Related to aws#7746 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While CDK Pipelines is the idiomatic way of deploying ECS applications in CDK,
it does not handle the case where the application's source code is kept in a separate source code repository from the CDK infrastructure code.
This adds a new class to the ECS module,
TagParameterContainerImage, that allows deploying a service managed that way through CodePipeline.Related to #1237
Related to #7746
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license