Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stepfunctions-tasks): instance type cannot be provided to SageMakerCreateEndpointConfig as input path #11749

Merged
merged 15 commits into from
Dec 1, 2020
Merged

fix(stepfunctions-tasks): instance type cannot be provided to SageMakerCreateEndpointConfig as input path #11749

merged 15 commits into from
Dec 1, 2020

Conversation

Stacy-D
Copy link
Contributor

@Stacy-D Stacy-D commented Nov 27, 2020 •
edited by shivlaks
Loading

Closes #11605

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 27, 2020 •
edited
Loading

@mergify
Copy link
Contributor

mergify bot commented Nov 27, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@Stacy-D Stacy-D changed the title fix(stepfunctions-tasks) allow providing ec2.InstanceType to SageMakerCreateEndpointConfig as input path fix(stepfunctions-tasks): allow providing ec2.InstanceType to SageMakerCreateEndpointConfig as input path Nov 27, 2020
@shivlaks shivlaks changed the title fix(stepfunctions-tasks): allow providing ec2.InstanceType to SageMakerCreateEndpointConfig as input path fix(stepfunctions-tasks): instance type cannot be provided to SageMakerCreateEndpointConfig as input path Nov 27, 2020
shivlaks
shivlaks approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stacy-D thanks for the fix!!

shivlaks
shivlaks previously approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stacy-D thanks for the fix!!

@mergify
Copy link
Contributor

mergify bot commented Nov 27, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 27, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@Stacy-D
Copy link
Contributor Author

Stacy-D commented Nov 30, 2020

@shivlaks Thanks for the quick review.
I'm not sure why semantic PR rule fails and prevents merging, can you help with it?

@mergify
Copy link
Contributor

mergify bot commented Nov 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed shivlaks’s stale review November 30, 2020 18:46

Pull request has been modified.

shivlaks
shivlaks previously approved these changes Nov 30, 2020
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Nov 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed shivlaks’s stale review November 30, 2020 19:47

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 631eb16
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5fb0ea6 into aws:master Dec 1, 2020
@zhuoyue0515 zhuoyue0515 mentioned this pull request Dec 8, 2020
Closed
@syeehyn syeehyn mentioned this pull request Jul 22, 2021
Merged
mergify bot pushed a commit that referenced this pull request Jul 26, 2021
@syeehyn
fix(stepfunctions-tasks): instance type cannot be provided to SageMak…
6f2384d 
…erCreateTransformJob as input path (#15726)

as referred in #11605 in SageMakerCreateTransformJob has the same kind of issue.

similar solution can be found at #11749


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Aug 3, 2021
@syeehyn @TikiTDO
fix(stepfunctions-tasks): instance type cannot be provided to SageMak…
7b1d689 
…erCreateTransformJob as input path (aws#15726)

as referred in aws#11605 in SageMakerCreateTransformJob has the same kind of issue.

similar solution can be found at aws#11749


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@syeehyn @hollanddd
fix(stepfunctions-tasks): instance type cannot be provided to SageMak…
c06c709 
…erCreateTransformJob as input path (aws#15726)

as referred in aws#11605 in SageMakerCreateTransformJob has the same kind of issue.

similar solution can be found at aws#11749


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks approved these changes

Assignees

@shivlaks shivlaks

Labels
@aws-cdk/aws-stepfunctions-tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stepfunctions-tasks] SageMakerCreateEndpointConfig cannot use JSONPath.stringAt for ec2.InstanceType
3 participants
@Stacy-D @aws-cdk-automation @shivlaks