chore: init templates for v2

[njlynch]

Creates the v2 init templates by first copying the v1 init templates wholesale,
and then applying a series of changes to make the templates v2-compatible.
This mostly involves adjusting dependencies and import statements.

For ease of review, I suggest looking at the second commit, which is just the
changes to the v2 templates from the v1 baseline.

One call-out -- we don't (yet) have a plan for assert for v2. This is being
tracked in the v2 project board, but is currently out of scope for the alpha
release. This means I had to rewrite several tests that used assert to doing
much simpler/uglier validations. I used the Java tests as the basis for these
rewrites.

Tested against a recent build artifact to verify correctness.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[nija-at]

Looks good to me.

Have you had a chance to look at whether we can run some of the unit tests in master? Would be nice to see if we can catch errors as part of PRs here rather than wait for the build in v2-main.

If not, we should update the v2-main branch to run these tests instead.

[njlynch]

Have you had a chance to look at whether we can run some of the unit tests in master? Would be nice to see if we can catch errors as part of PRs here rather than wait for the build in v2-main.

I've been working at it, but haven't yet found the right combination of re-writing the source and messing with mocks to make this work. Happy to have another set of eyes if you have the time; I don't feel I'm making significant progress.

This is why (IMO) this should only be committed to v2-main, so the errors are caught on the same branch where the code is based, but we've already discussed that. :) With this as-is, we're going to be in the situation where: (1) someone commits v2 template changes to master (2) foward-merge job pulls change to v2 (3) unit tests fail on merge job.

If not, we should update the v2-main branch to run these tests instead.

This is already happening. See #11703 and the logs, where the tests are failing because the /v2/ directory doesn't exist yet.

[nija-at]

Ok fair. Then let's move this to the v2-main branch. But please make sure that all changes in this PR are on the /v2 folder only.

[njlynch]

While I still like having these on v2 only, I have managed to get the mocks working to be able to run both unit tests on master. See latest commit.

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 0f8d167
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository