You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the FunctionOptions were leaking into core where a cache key is
calculated in asset staging. Some of those options have circular references
making it impossible to calculate a cache key with the current implementation.
Another PR is needed to make the cache key calculation in core more
robust.
… a VPC
All the `FunctionOptions` were leaking into `core` where a cache key is
calculated in asset staging. For a function in a VPC, those options have
circular references making it impossible to calculate a cache key with
the current implementation.
Another PR is needed to make the cache key calculation in core more
robust.
BREAKING CHANGE: bundling customization options like `minify` or
`sourcemap` are now gathered under a new `bundling` prop.
I am getting the same issue when trying to add defined IAM Role to the NodeJS function, hopefully this is fixed here too but thought I would mention it
hopefully this is fixed here too but thought I would mention it
Yes, it should be the case.
jogold
changed the title
fix(lambda-nodejs): maximum call stack size exceeded with function in a VPC
fix(lambda-nodejs): maximum call stack size exceeded or converting circular structure to JSON
Nov 26, 2020
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jogold
changed the title
All the
FunctionOptionswere leaking intocorewhere a cache key iscalculated in asset staging. Some of those options have circular references
making it impossible to calculate a cache key with the current implementation.
Another PR is needed to make the cache key calculation in
coremorerobust.
Closes #11693
Closes #11726
Closes #11762
BREAKING CHANGE: bundling customization options like
minifyorsourceMapare now gathered under a newbundlingprop.bundlingEnvironmentis nowbundling.environmentbundlingDockerImageis nowbundling.dockerImageBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license