Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-ecs): Add type annotation for the workaround to missing import in d.ts file #1117

Merged
merged 2 commits into from
Nov 8, 2018
Merged

fix(aws-ecs): Add type annotation for the workaround to missing import in d.ts file #1117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f238917
Add type annotation for the workaround to missing import in d.ts file
cockscomb Nov 8, 2018
f18819b
Add explanatory comment
rix0rrr Nov 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/@aws-cdk/aws-ecs/lib/fargate/fargate-task-definition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,10 @@ export class FargateTaskDefinition extends TaskDefinition {
/**
* The configured network mode
*/
public readonly networkMode = NetworkMode.AwsVpc;
public readonly networkMode: NetworkMode = NetworkMode.AwsVpc;
// NOTE: Until the fix to https://github.com/Microsoft/TypeScript/issues/26969 gets released,
// we need to explicitly write the type here, as type deduction for enums won't lead to
// the import being generated in the .d.ts file.

constructor(parent: cdk.Construct, name: string, props: FargateTaskDefinitionProps = {}) {
super(parent, name, {
Expand Down