Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish cdk-integ-tools as separate package #11155

Closed
wants to merge 1 commit into from

Conversation

workeitel
Copy link
Contributor

Very helpful for testing construct libraries.

There was couple of times discussed in #993, aws/aws-cdk-rfcs#89, #2898, #6429 and I think it's time to make it public :)


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Very helpful for testing construct libraries.
@gitpod-io
Copy link

gitpod-io bot commented Oct 27, 2020

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: e6657bc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I appreciate the enthusiasm but we're not comfortable publishing the package as-is.

I suggest you use jest's expect(...).toMatchSnapshot() instead.

@workeitel
Copy link
Contributor Author

I agree, using jest's functionality is a good start. But the cdk-integ-tools package takes care of canonicalizing the template and makes it significantly easier to create the snapshot by creating and deleting the CloudFormation stack. @aws-cdk/assert makes it easy to compare parts of the stack but cdk-integ-tools is important for integration tests.

@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 11, 2020

I know. We have plans to do work in this area, though I can't promise any dates. We will revisit at that time. For now, this tool isn't production ready yet and we'd be distracted supporting it if we released it.

@rix0rrr rix0rrr closed this Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants