chore: CodeBuild build errors when branch is not 'master' #10868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that the shell conditional added returns a non-zero exit code when the branch is not 'master'. Switch strategies so that the environment variable comparison is actually done at deploy time and sets a final environment variable.
|
|
rix0rrr
requested changes
Oct 14, 2020
buildspec.yaml
Outdated
| # we bump here so that our master version won't be identical to the latest published version during tests. | ||
| # otherwise this causes problems with verdaccio mirroring. | ||
| - '[ ${GIT_BRANCH} = ${REGRESSION_TESTS_BRANCH} ] && /bin/bash ./bump-candidate.sh' | ||
| - /bin/bash ./scripts/bump-candidate.sh |
There was a problem hiding this comment.
I'd rather keep the flag visible in the buildspec.
The actual problem here is the &&. We should replace this with if ${BUMP_CANDIDATE:-false}; then ./bump-candidate.sh; fi
|
|
rix0rrr
approved these changes
Oct 15, 2020
iliapolo
approved these changes
Oct 15, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
njlynch
added a commit
that referenced
this pull request
Oct 15, 2020
Build is failing with: "/bin/bash: ./bump-candidate.sh: No such file or directory" Failure caused by script move in #10868.
mergify bot
pushed a commit
that referenced
this pull request
Oct 15, 2020
Build is failing with: "/bin/bash: ./bump-candidate.sh: No such file or directory" Failure caused by script move in #10868. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that the shell conditional added returns a non-zero exit
code when the branch is not 'master'.
Switch strategies so that the environment variable comparison is
actually done at deploy time and sets a final environment variable.
Corresponding change: https://github.com/aws/cdk-ops/pull/758
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license