-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iam): User.fromUserName not implementing IUSER functions #10527
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -145,6 +145,9 @@ export class User extends Resource implements IIdentity, IUser { | |
public readonly assumeRoleAction: string = 'sts:AssumeRole'; | ||
public readonly policyFragment: PrincipalPolicyFragment = new ArnPrincipal(arn).policyFragment; | ||
private defaultPolicy?: Policy; | ||
private readonly groups = new Array<any>(); | ||
private readonly managedPolicies = new Array<IManagedPolicy>(); | ||
private readonly attachedPolicies = new AttachedPolicies(); | ||
|
||
public addToPolicy(statement: PolicyStatement): boolean { | ||
return this.addToPrincipalPolicy(statement).statementAdded; | ||
|
@@ -159,16 +162,18 @@ export class User extends Resource implements IIdentity, IUser { | |
return { statementAdded: true, policyDependable: this.defaultPolicy }; | ||
} | ||
|
||
public addToGroup(_group: IGroup): void { | ||
throw new Error('Cannot add imported User to Group'); | ||
public addToGroup(group: IGroup): void { | ||
this.groups.push(group.groupName); | ||
} | ||
|
||
public attachInlinePolicy(_policy: Policy): void { | ||
throw new Error('Cannot add inline policy to imported User'); | ||
public attachInlinePolicy(policy: Policy): void { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will this actually add an inline policy to an already-existing |
||
this.attachedPolicies.attach(policy); | ||
policy.attachToUser(this); | ||
} | ||
|
||
public addManagedPolicy(_policy: IManagedPolicy): void { | ||
throw new Error('Cannot add managed policy to imported User'); | ||
public addManagedPolicy(policy: IManagedPolicy): void { | ||
if (this.managedPolicies.find(mp => mp === policy)) { return; } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment here. |
||
this.managedPolicies.push(policy); | ||
} | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is sufficient. If the
User
is being created you can add it to a group in this way, but fairly sure that's not how you do it if the User already exists.