Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support the 'Description' resource attribute #10522

Merged
merged 4 commits into from
Sep 26, 2020

Conversation

skinny85
Copy link
Contributor

One more resource attribute that we missed,
and that is needed for cfn-include to be able to handle ingesting all templates.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

One more resource attribute that we missed,
and that is needed for cfn-include to be able to handle ingesting all templates.
@skinny85 skinny85 requested a review from shivlaks September 25, 2020 01:04
@skinny85 skinny85 self-assigned this Sep 25, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 25, 2020
@skinny85 skinny85 added the pr-linter/exempt-readme The PR linter will not require README changes label Sep 25, 2020
@shivlaks shivlaks added the pr/do-not-merge This PR should not be merged at this time. label Sep 25, 2020
Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! some small suggestions - feel free to make a call on them and drop the do-not-merge as you see fit!

packages/@aws-cdk/core/lib/cfn-resource.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/core/lib/cfn-resource.ts Outdated Show resolved Hide resolved
@skinny85 skinny85 removed the pr/do-not-merge This PR should not be merged at this time. label Sep 26, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 72efdd1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d68ce2f into aws:master Sep 26, 2020
@skinny85 skinny85 deleted the feat/description-resource-attribute branch September 28, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants