fix(cli): stack outputs aren't sorted #10328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
added
the
pr-linter/exempt-test
rix0rrr
changed the title
rix0rrr
previously approved these changes
Sep 16, 2020
mergify
bot
dismissed
rix0rrr’s stale review
Pull request has been modified.
rix0rrr
approved these changes
Sep 21, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
cdk deploythe stack outputs to the terminal are currently returned in the same order as thedescribe stacksAPI call, which does not seem to provide a contract on ordering, per the docs.This change sorts the keys of the stack outputs before display, which is consistent with "outputs" tab in the AWS CloudFormation console.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license