feat(codedeploy): change LambdaDeploymentGroup default managed policy to AWSCodeDeployRoleForLambdaLimited #10276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(cli): incorrect options passing to `shell` in integration tests…
fix(appsync): strongly type `expires` prop in apiKeyConfig (aws#9122)
skinny85
changed the title
skinny85
changed the title
skinny85
approved these changes
Sep 21, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
skinny85
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The managed policy
AWSCodeDeployRoleForLambdaused for Lambda deployments has broad permissions, providing publish access to all SNS topics within the customer's accounts.This change replaces that with a new policy
AWSCodeDeployRoleForLambdaLimitedwhich removes those permissions.This should be safe, as the SNS publish permission is only ever used when setting up
triggers,and we don't support that feature in
LambdaDeploymentGroup.BREAKING CHANGE: the default policy for
LambdaDeploymentGroupno longer containssns:Publishon*permissionsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license