Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfn-include): add support for Hooks #10143

Merged
merged 4 commits into from
Sep 4, 2020

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented Sep 3, 2020

Add support for creating and retrieving the new Hook
CloudFormation objects used in blue-green deployments.
In order to do that, add new CfnHook and
CfnCodeDeployBlueGreenHook classes to core.

Closes #9713


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@skinny85 skinny85 requested review from njlynch and shivlaks September 3, 2020 01:26
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 3, 2020
@skinny85
Copy link
Contributor Author

skinny85 commented Sep 3, 2020

Forgot the ReadMe update: will fix.

Add support for creating and retrieving the new Hook
CloudFormation objects used in blue-green deployments.
In order to do that, add new CfnHook and
CfnCodeDeployBlueGreenHook classes to core.

Closes aws#9713
@skinny85 skinny85 force-pushed the feat/cfn-include-hooks branch from b0259fa to 2bb3d53 Compare September 3, 2020 19:48
@njlynch njlynch added the pr/do-not-merge This PR should not be merged at this time. label Sep 4, 2020
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one nit below.

@skinny85 skinny85 removed the pr/do-not-merge This PR should not be merged at this time. label Sep 4, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ca660e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4de68c0 into aws:master Sep 4, 2020
@skinny85 skinny85 deleted the feat/cfn-include-hooks branch September 4, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cfn-include] Add support for retrieving Hook objects from the template
3 participants