Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cloudformation-diff] DependsOn array arguments are incorrectly considered unequal in certain cases #9813

Closed
comcalvi opened this issue Aug 18, 2020 · 0 comments · Fixed by #9814
Closed

[cloudformation-diff] DependsOn array arguments are incorrectly considered unequal in certain cases #9813

comcalvi opened this issue Aug 18, 2020 · 0 comments · Fixed by #9814
Assignees
@shivlaks
Labels
@aws-cdk/cloudformation-diff bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Milestone
[DevPreview] @aws...

Comments

@comcalvi
Copy link
Contributor

DependsOn: "A" and DependsOn: ["A"] should be equivalent.

DependsOn: ["A", "B"] and DependsOn: ["B", "A"] should be equivalent.

Currently, they are not.

I will be opening a PR to address this.

This is 🐛 Bug Report
@comcalvi comcalvi added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 18, 2020
@comcalvi comcalvi changed the title [cloudformation-diff] [cloudformation-diff] DependsOn array arguments are incorrectly considered unequal in certain cases Aug 18, 2020
@comcalvi comcalvi mentioned this issue Aug 18, 2020
Merged
@mergify mergify bot closed this as completed in #9814 Aug 19, 2020
mergify bot pushed a commit that referenced this issue Aug 19, 2020
@comcalvi
fix(cloudformation-diff): DependsOn singleton arrays aren't equal to …
49cdb47 
…string values (#9814)

----

Closes #9813 

This allows

`DependsOn: "A"` and `DependsOn: ["A"]`

and

`DependsOn: ["A", "B"]` and `DependsOn: ["B", "A"]` to be equivalent.

----

It also fixes a bug that would cause 

`BucketName: { 'Fn::Select': [0, ['name2', 'name1']] }`

and

`BucketName: { 'Fn::Select': [0, ['name1', 'name2']] }`

to be equal.

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
misterjoshua pushed a commit to misterjoshua/aws-cdk that referenced this issue Aug 19, 2020
@comcalvi @misterjoshua
fix(cloudformation-diff): DependsOn singleton arrays aren't equal to …
d24d08a 
…string values (aws#9814)

----

Closes aws#9813 

This allows

`DependsOn: "A"` and `DependsOn: ["A"]`

and

`DependsOn: ["A", "B"]` and `DependsOn: ["B", "A"]` to be equivalent.

----

It also fixes a bug that would cause 

`BucketName: { 'Fn::Select': [0, ['name2', 'name1']] }`

and

`BucketName: { 'Fn::Select': [0, ['name1', 'name2']] }`

to be equal.

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivlaks shivlaks

Labels
@aws-cdk/cloudformation-diff bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
[DevPreview] @aws-cdk/cloudformation-...
Development

Successfully merging a pull request may close this issue.

fix(cloudformation-diff): DependsOn singleton arrays aren't equal to string values comcalvi/aws-cdk
3 participants
@skinny85 @shivlaks @comcalvi