Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cfn-include] Condition YAML short form #9785

Closed
skinny85 opened this issue Aug 18, 2020 · 0 comments · Fixed by #9865
Closed

[cfn-include] Condition YAML short form #9785

skinny85 opened this issue Aug 18, 2020 · 0 comments · Fixed by #9865
Assignees
@njlynch
Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package bug This issue is a bug. effort/medium Medium work item – several days of effort in-progress This issue is being actively worked on. p1
Milestone
[DevPreview] @aws...

Comments

@skinny85
Copy link
Contributor

As it turns out, this is valid in CloudFormation:

Conditions:
  RegionSupportsInspector: !Or [!Condition APRegionSupportsInspector, !Condition EURegionSupportsInspector, !Condition USRegionSupportsInspector]

We need to add support for this short form into our YAML custom tags.
@github-actions github-actions bot added the @aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package label Aug 18, 2020
@skinny85 skinny85 added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Aug 18, 2020
njlynch added a commit that referenced this issue Aug 20, 2020
@njlynch
fix(cfn-include): short form for Condition
a55d730 
Add YAML support for the short form of Condition `!Condition`.

fixes #9785
@njlynch njlynch mentioned this issue Aug 20, 2020
Merged
@njlynch njlynch assigned njlynch and unassigned skinny85 Aug 20, 2020
@njlynch njlynch added the in-progress This issue is being actively worked on. label Aug 20, 2020
@mergify mergify bot closed this as completed in #9865 Aug 20, 2020
mergify bot pushed a commit that referenced this issue Aug 20, 2020
@njlynch
fix(cfn-include): short form for Condition (#9865)
371e8da 
Add YAML support for the short form of Condition: `!Condition`.

fixes #9785

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package bug This issue is a bug. effort/medium Medium work item – several days of effort in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
[DevPreview] @aws-cdk/cloudformation-...
Development

Successfully merging a pull request may close this issue.

fix(cfn-include): short form for Condition aws/aws-cdk
2 participants
@skinny85 @njlynch