You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running yarn build as documented in CONTRIBUTING fails when there is a space in the path. Specifically, running from WSL2 and maven (mvn) is found in /mnt/c/Program Files.
Reproduction Steps
WSL2
mvn is installed in windows partition and in the WSL2 path.
yarn build or ./scripts/check-prerequisites.sh
What did you expect to happen?
Expected to check the mvn version and either fail due to incorrect version or succeed on correct version.
What actually happened?
Checking if mvn is installed... ./scripts/check-prerequisites.sh: line 25: [: /mnt/c/Program: binary operator expected
./scripts/check-prerequisites.sh: line 25: [: too many arguments
Ok
Prereq check before `yarn build` fails when there are spaces in the
path. This is common for WSL2 on windows. For example, mvn is in the
path at `/mnt/c/Program Files/`.
Testing - Ran check on linux paths and windows paths with and without
spaces. Tested with correct version, wrong version, and missing dep.
fixes#9749
Running
yarn build
as documented in CONTRIBUTING fails when there is a space in the path. Specifically, running from WSL2 and maven (mvn
) is found in/mnt/c/Program Files
.Reproduction Steps
mvn
is installed in windows partition and in the WSL2 path.yarn build
or./scripts/check-prerequisites.sh
What did you expect to happen?
Expected to check the
mvn
version and either fail due to incorrect version or succeed on correct version.What actually happened?
Checking if mvn is installed... ./scripts/check-prerequisites.sh: line 25: [: /mnt/c/Program: binary operator expected ./scripts/check-prerequisites.sh: line 25: [: too many arguments Ok
Environment
Other
PR: #9750
This is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: