Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cfn-include] Add support for retrieving Mapping objects from the template #9711

Closed
5 tasks
skinny85 opened this issue Aug 14, 2020 · 0 comments · Fixed by #9777
Closed
5 tasks

[cfn-include] Add support for retrieving Mapping objects from the template #9711

skinny85 opened this issue Aug 14, 2020 · 0 comments · Fixed by #9777
Assignees
@skinny85
Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Milestone
[DevPreview] @aws...

Comments

@skinny85
Copy link
Contributor

skinny85 commented Aug 14, 2020 •
edited
Loading

Similarly like allow retrieving Parameters, Conditions, Resources, and Outputs from the included template today (see the module ReadMe), do the same for Mapping objects.

  • Add a new method to CfnInclude, public getMapping(name: string): CfnMapping
  • Create the CfnMapping instances in the constructor of CfnInclude
  • Stop rendering the Mappings section of the template unchanged here
  • When handling Fn::FindInMap here, actually search out the Mapping referenced by the first argument (to handle renaming logical IDs). Will most likely require adding a new method to the ICfnFinder interface
  • Unit tests
@github-actions github-actions bot added the @aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package label Aug 14, 2020
@skinny85 skinny85 mentioned this issue Aug 14, 2020
Closed
@skinny85 skinny85 added feature-request A feature should be added or improved. effort/small Small work item – less than a day of effort p2 effort/medium Medium work item – several days of effort and removed effort/small Small work item – less than a day of effort labels Aug 14, 2020
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Aug 17, 2020
@skinny85
feat(cfn-include): add support for retrieving Mapping objects from th…
c7c3801 
…e template

Fixes aws#9711
@skinny85 skinny85 mentioned this issue Aug 17, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Aug 18, 2020
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Aug 18, 2020
@skinny85
feat(cfn-include): add support for retrieving Mapping objects from th…
f6df396 
…e template

Fixes aws#9711
@mergify mergify bot closed this as completed in #9777 Aug 19, 2020
mergify bot pushed a commit that referenced this issue Aug 19, 2020
@skinny85
feat(cfn-include): add support for retrieving Mapping objects from th…
a038304 
…e template (#9777)

Fixes #9711

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
misterjoshua pushed a commit to misterjoshua/aws-cdk that referenced this issue Aug 19, 2020
@skinny85 @misterjoshua
feat(cfn-include): add support for retrieving Mapping objects from th…
6f6dd8b 
…e template (aws#9777)

Fixes aws#9711

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
[DevPreview] @aws-cdk/cloudformation-...
Development

Successfully merging a pull request may close this issue.

feat(cfn-include): add support for retrieving Mapping objects from the template skinny85/aws-cdk
2 participants
@skinny85 @SomayaB