Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amplify] missing enableBranchAutoDeletion option #9650

Closed
2 tasks
martinbiard opened this issue Aug 12, 2020 · 1 comment · Fixed by #9663
Closed
2 tasks

[amplify] missing enableBranchAutoDeletion option #9650

martinbiard opened this issue Aug 12, 2020 · 1 comment · Fixed by #9663
Assignees
Labels
@aws-cdk/aws-amplify Related to AWS Amplify feature-request A feature should be added or improved. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged.

Comments

@martinbiard
Copy link

The amplify.App class is missing the enableBranchAutoDeletion option.

Use Case

We would like to start using the experimental amplify.App but currently have to use amplify.CfnApp for the ability to activate the enableBranchAutoDeletion option.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@martinbiard martinbiard added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 12, 2020
@github-actions github-actions bot added the @aws-cdk/aws-amplify Related to AWS Amplify label Aug 12, 2020
@jogold
Copy link
Contributor

jogold commented Aug 13, 2020

@martinbiard you can use the "escape hatch" in the meantime:

const app = new amplify.App(this, 'App', { ... });
const cfnApp = app.node.defaultChild as amplify.CfnApp;
cfnApp.addPropertyOverride('EnableBranchAutoDeletion', true);

jogold added a commit to jogold/aws-cdk that referenced this issue Aug 13, 2020
Add the `autoBranchDeletion` prop to control automatic branch deletion.

Closes aws#9650
jogold added a commit to jogold/aws-cdk that referenced this issue Aug 13, 2020
Add the `autoBranchDeletion` prop to control automatic branch deletion.

Closes aws#9650
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Aug 13, 2020
@mergify mergify bot closed this as completed in #9663 Aug 17, 2020
mergify bot pushed a commit that referenced this issue Aug 17, 2020
Add the `autoBranchDeletion` prop to control automatic branch deletion.

Closes #9650


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-amplify Related to AWS Amplify feature-request A feature should be added or improved. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants