Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cloudfront-origins] All origin access identities have identical names #9580

Closed
justin8 opened this issue Aug 11, 2020 · 1 comment · Fixed by #9829
Closed

[cloudfront-origins] All origin access identities have identical names #9580

justin8 opened this issue Aug 11, 2020 · 1 comment · Fixed by #9829
Assignees
@njlynch
Labels
@aws-cdk/aws-cloudfront-origins Related to CloudFront Origins for the CDK CloudFront Library bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1

Comments

@justin8
Copy link
Contributor

justin8 commented Aug 11, 2020

Currently when you use the new cloudfront-origins package to create S3 origins, it generates an OAI with the exact same name each time. If you have multiple origins/distributions you end up with a list of identities all labeled Allows CloudFront to reach the bucket. In the console when you inspect the distribution it resolves the comment/name field for this, so you can't tell what distribution is using what without enumerating them using the API.

I'd suggest propagating the origin's logical name in to the comment field to make it clearer which OAI is in use for which bucket/origin.

Reproduction Steps

What did you expect to happen?

What actually happened?

Environment

  • CLI Version : 1.57
  • Framework Version: 1.57
  • Node.js Version: 1.12
  • OS : MacOS
  • Language (Version): all

Other

This is 🐛 Bug Report
@justin8 justin8 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 11, 2020
@SomayaB SomayaB added the @aws-cdk/aws-cloudfront-origins Related to CloudFront Origins for the CDK CloudFront Library label Aug 11, 2020
@iliapolo iliapolo assigned njlynch and unassigned iliapolo Aug 19, 2020
@njlynch njlynch added effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 19, 2020
njlynch added a commit that referenced this issue Aug 19, 2020
@njlynch
fix(cloudfront): All origin access identities have identical names
7432ab0 
Replaces the single hard-coded value for the origin access identity comment
field with one that refernces the origin's ID.

fixes #9580
@njlynch njlynch mentioned this issue Aug 19, 2020
Merged
@njlynch
Copy link
Contributor

njlynch commented Aug 19, 2020

Thanks for the bug report! I've posted a PR for the fix.

@mergify mergify bot closed this as completed in #9829 Aug 19, 2020
mergify bot pushed a commit that referenced this issue Aug 19, 2020
@njlynch
fix(cloudfront): all origin access identities have identical names (#…
ca79188 
…9829)

Replaces the single hard-coded value for the origin access identity comment
field with one that refernces the origin's ID.

fixes #9580


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-cloudfront-origins Related to CloudFront Origins for the CDK CloudFront Library bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cloudfront): all origin access identities have identical names aws/aws-cdk
4 participants
@justin8 @njlynch @iliapolo @SomayaB