-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli, lambda] skip expensive bundling during "cdk list" and other operations where the stack is not needed #9540
Comments
@eladb should/could constructs be aware of what triggered their "construction"? There is also the case when doing |
Generally we stayed away from special casing various CLI commands, but I can see why the heavy lifting done in bundling could be problematic for I do think we may need to write a short RFC about this to vet this with the team. Is that something you'd like to take? We are actually trying to simplify the RFC format so it really should not be too hard. Copying @shivlaks who owns the CLI. |
Could a EDIT: This does not solve the issue of a synth with a |
We can definitely add a |
@eladb do you still want to see an RFC for this or can we go for your suggestion:
|
) By default asset bundling is skipped for `cdk list` and `cdk destroy`. For `cdk deploy`, `cdk diff` and `cdk synthesize` the default is to bundle assets for all stacks unless `exclusively` is specified. In this case, only the listed stacks will have their assets bundled. Closes #9540 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
up, we still need this |
Running
cdk list
on a project that uses custom asset bundling results in the following observed issues:.cdk.staging
resulting in wasted spaceNB: I am using
aws_lambda_python.PythonFunction
Reproduction Steps
What did you expect to happen?
Running
cdk list
should quickly return the list of stacks in the app, and should have no side effects such as triggering a new build.What actually happened?
Output
Environment
Other
This is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: