Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[contributing.md] awslint link broken #9394

Closed
ReidWeb opened this issue Aug 1, 2020 · 1 comment · Fixed by #9398
Closed

[contributing.md] awslint link broken #9394

ReidWeb opened this issue Aug 1, 2020 · 1 comment · Fixed by #9398
Labels
documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@ReidWeb
Copy link
Contributor

ReidWeb commented Aug 1, 2020

CONTRIBUTING.MD guide.

The contributing guide talks about awslint, but the awslint README link to it is a broken link, unsure as to where it should go.

This is a 📕 documentation issue
@ReidWeb ReidWeb added documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 1, 2020
@Chriscbr Chriscbr mentioned this issue Aug 2, 2020
Merged
@Chriscbr
Copy link
Contributor

Chriscbr commented Aug 2, 2020

Good catch, it looks like this link wasn't updated when the awslint package was published as an external module in #8558 - the correct file you're looking for is here. 🙂

@mergify mergify bot closed this as completed in #9398 Aug 3, 2020
mergify bot pushed a commit that referenced this issue Aug 3, 2020
@Chriscbr
docs(core): fix broken link to awslint (#9398)
71be72d 
Fixes #9394

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
curtiseppel pushed a commit to curtiseppel/aws-cdk that referenced this issue Aug 11, 2020
@Chriscbr
docs(core): fix broken link to awslint (aws#9398)
e285831 
Fixes aws#9394

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(core): fix broken link to awslint Chriscbr/aws-cdk
2 participants
@ReidWeb @Chriscbr