feat(appsync): add x-ray parameter to AppSync

[tomoki10]

Close: #7640

• Adding a boolean prop for xrayEnabled
• Linking it to the xrayEnabled prop in class CfnGraphQLApi from appsync.generated.ts file that is generated on yarn build
• Writing a unit test to check whether that the boolean property is set in the CloudFormation Template

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[mergify]

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

[BryanPan342]

Thanks for the contribution @tomoki10!!

Just a couple minor things before I'm ready to ship this out 😊

[BryanPan342]

The property doesn't need to be configured here. If it is undefined in CloudFormations, Cfn will configure the AppSync without x-ray support by default.

Suggested change

	xrayEnabled: props.xrayEnabled || false,
	xrayEnabled: props.xrayEnabled,

[tomoki10]

@BryanPan342
Thank you for your comment.
I will fix it along with the integration test.

[BryanPan342]

I would rather us either put a description of what x-ray support is or not include it at all in the README.

Since it is a feature, I think in order to avoid the linter error, I would be okay with just adding the prop to the example section.

Like as follows:

const api = new appsync.GraphQLApi(stack, 'Api', {
  name: 'demo',
  schemaDefinition: appsync.SchemaDefinition.FILE,
  schemaDefinitionFile: join(__dirname, 'schema.graphql'),
  authorizationConfig: {
    defaultAuthorization: {
      authorizationType: appsync.AuthorizationType.IAM
    },
  },
  xrayEnabled: true,
});

@MrArnoldPalmer wdyt?

[tomoki10]

I'll fix it as commented.

Pull request has been modified.

[BryanPan342]

LGTM 🎉

Thanks for the contribution @tomoki10!!

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[BryanPan342]

@tomoki10 looks like the error is the following:

Property 'schemaDefinition' is missing in type '{ authorizationConfig: {}; name: string; schemaDefinitionFile: string; xrayEnabled: true; }' but required in type 'GraphQLApiProps'.

This is coming from the breaking change that we have in the works at the moment. If you just add a prop similar to the line above. We should be good to go.

aws-cdk/packages/@aws-cdk/aws-appsync/test/appsync.test.ts

Lines 29 to 34 in 3ad8e8e

	const api = new appsync.GraphQLApi(stack, 'api', {
	authorizationConfig: {},
	name: 'api',
	schemaDefinition: appsync.SchemaDefinition.FILE,
	schemaDefinitionFile: path.join(__dirname, 'appsync.test.graphql'),
	});

Pull request has been modified.

Pull request has been modified.

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 93aaa8d
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).