Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cfn include] add support for nested stacks #8978

Closed
1 of 2 tasks
comcalvi opened this issue Jul 9, 2020 · 0 comments · Fixed by #8980
Closed
1 of 2 tasks

[cfn include] add support for nested stacks #8978

comcalvi opened this issue Jul 9, 2020 · 0 comments · Fixed by #8980
Assignees
@skinny85
Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@comcalvi
Copy link
Contributor

comcalvi commented Jul 9, 2020

Allow users to include a single template, and with that call include any nested templates they specify.

Use Case

Nested stacks are currently not accessible unless each of them are manually included. This feature allows them to be included one time and intuitively accessed from their parent stack.

Proposed Solution

I will be opening a PR to address this.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@comcalvi comcalvi added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 9, 2020
@SomayaB SomayaB changed the title [cfn-include] add support for nested stacks [cfn include] add support for nested stacks Jul 9, 2020
@github-actions github-actions bot added the @aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package label Jul 9, 2020
@skinny85 skinny85 added effort/large Large work item – several weeks of effort in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels Jul 9, 2020
@comcalvi comcalvi mentioned this issue Jul 9, 2020
Merged
@mergify mergify bot closed this as completed in #8980 Jul 16, 2020
mergify bot pushed a commit that referenced this issue Jul 16, 2020
@comcalvi
feat(cfn-include): add support for nested stacks (#8980)
bf12456 
Fixes #8978

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
curtiseppel pushed a commit to curtiseppel/aws-cdk that referenced this issue Aug 11, 2020
@comcalvi
feat(cfn-include): add support for nested stacks (aws#8980)
de42cda 
Fixes aws#8978

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/cloudformation-include Issues related to the "CFN include v.20" package effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cfn-include): add support for nested stacks comcalvi/aws-cdk
2 participants
@skinny85 @comcalvi