-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FargatePlatformVersion not getting respected in StepFunctions when using CDK #8610
Comments
@yashwanthkp thanks for reporting the issue and detailed repro steps. I'd expect the output to include the fargate version as well. I'll investigate to see why that property is not being honoured and provide an update. |
Thanks for the response! Is there a tentative date for the fix for this? |
@yashwanthkp added a commit to #8451 that honors the fargate platform version. Note that this is the newer style of calling service integrations with Step Functions, which we are aligning so we can push Step Functions towards |
@shivlaks Thanks for the response! Which version of CDK will the above change be rolled out in? |
@yashwanthkp there's still some feedback to work through before it'll be merged and i'm currently on it. |
) Replacement for the current implementation of `ECS` service integration. Merges state and service integration properties and represents them as a construct. The notable differences from the current implementation are: * single implementation class`runTask` with an added `launchTarget` required property where the properties specific to the launch type are specified * linter disable of `ref-via-interface` as we need to use `TaskDefinition` because properties that are not known for imported task definitions are required * older implementations have been marked deprecated with direction to the replacement. Left all of the unit tests (except fargate platform version which was not previously honored) and integ test expectations verbatim to ensure that we have not lost fidelity. BREAKING CHANGE: * `containerName` is not supported as an override anymore and has been replaced by `containerDefinition` Closes #8610 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
FargatePlatformVersion not getting respected in StepFunctions when using CDK
Reproduction Steps
I have a fargate task as a step in my step-function with the below code which tries to start the task on FargatePlatform version 1.4.
After I run
cdk deploy
, I end up getting the below ASL codeI was expecting a new line
"PlatformVersion": "1.4.0"
in the generated ASL.Error Log
There are no errors on
cdk deploy
. However the stepfunction created does not have"PlatformVersion": "1.4.0"
override in ASL.Environment
Other
NA
This is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: