Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support For HostedZoneTags #7445

Closed
kferrone opened this issue Apr 19, 2020 · 4 comments · Fixed by #7531
Closed

Support For HostedZoneTags #7445

kferrone opened this issue Apr 19, 2020 · 4 comments · Fixed by #7531
Assignees
@shivlaks
Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 bug This issue is a bug. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved.

Comments

@kferrone
Copy link

The HostedZone Construct does not support the HostedZoneTags. Please add support for these. In the mean time I had to make my hosted zone from CfnResource which did work and create the tags.

Use Case

Differentiate between numerous hosted zones with same name. Also useful for the external-dns project.

Proposed Solution

Add new field to the HostedZone props for the tags.

This is a 🚀 Feature Request
@kferrone kferrone added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 19, 2020
@shivlaks shivlaks self-assigned this Apr 20, 2020
@shivlaks shivlaks added @aws-cdk/aws-route53 Related to Amazon Route 53 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Apr 20, 2020
@san28
Copy link

san28 commented Apr 22, 2020

Will Tag.add also add tags under HostedZoneTags ?

https://docs.aws.amazon.com/cdk/latest/guide/tagging.html

@shivlaks
Copy link
Contributor

@san28 - that's how it should work but I suspect that because the Tag attribute is not named similar to tags for other resources, our logic is not identifying this as "taggable resource"

We had to add similar exemptions for Cognito UserPoolTags and EFS FileSystemTags here

We will need to add a similar property for HostedZoneTags
marking this as a bug.

@shivlaks shivlaks added bug This issue is a bug. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. and removed effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. labels Apr 23, 2020
shivlaks added a commit that referenced this issue Apr 23, 2020
@shivlaks
fix(route53) cannot add tags to HostedZone
8c0320f 
We don't classify `HostedZoneTags` as the tagging property
since it follows a naming convention where it's not called `Tags`.

`HostedZoneTags` are also an array of type `HostedZoneTag` objects that
enforce the `{Key: "...", Value: "..."}` convention.

This is similar to `FileSystemTags` property for `EFS`

Closes #7445
@shivlaks shivlaks mentioned this issue Apr 23, 2020
Merged
@mergify mergify bot closed this as completed in #7531 Apr 23, 2020
mergify bot pushed a commit that referenced this issue Apr 23, 2020
@shivlaks
fix(route53): cannot add tags to HostedZone (#7531)
2729804 
We don't classify `HostedZoneTags` as the tagging property
since it follows a naming convention where it's not called `Tags`.

`HostedZoneTags` are also an array of type `HostedZoneTag` objects that
enforce the `{Key: "...", Value: "..."}` convention.

This is similar to `FileSystemTags` property for `EFS`

Closes #7445
@kferrone
Copy link
Author

@san28 I can confirm that Tag.add did not work. This is what I expected as well.

@shivlaks
Copy link
Contributor

@kferrone it should work with 1.35.0. give it a try and let me how it goes!

@ymhiroki ymhiroki mentioned this issue Feb 25, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivlaks shivlaks

Labels
@aws-cdk/aws-route53 Related to Amazon Route 53 bug This issue is a bug. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(route53): cannot add tags to HostedZone aws/aws-cdk
3 participants
@kferrone @san28 @shivlaks