Multiple Assets In the same stack

[sentient-jbreindel]

Whenever I try to create a stack with multiple assets I receive the following error when I run cdk synth:

Error: There is already a Construct with name 'AssetBucket' in ApiStack [ApiStack]
    at ApiStack.addChild (/git/project/node_modules/@aws-cdk/cdk/lib/core/construct.js:287:19)
    at new Construct (/git/project/node_modules/@aws-cdk/cdk/lib/core/construct.js:38:20)
    at new BucketRef (/git/project/node_modules/@aws-cdk/aws-s3/lib/bucket.js:30:9)
    at new ImportedBucketRef (/git/project/node_modules/@aws-cdk/aws-s3/lib/bucket.js:519:9)
    at Function.import (/git/project/node_modules/@aws-cdk/aws-s3/lib/bucket.js:46:16)
    at new Asset (/git/project/node_modules/@aws-cdk/assets/lib/asset.js:48:42)
    at new ZipDirectoryAsset (/git/project/node_modules/@aws-cdk/assets/lib/asset.js:95:9)
    at new ApiStack (/git/project/index.js:100:24)
    at new App (/git/project/index.js:187:5)
    at Object.<anonymous> (/git/project/index.js:191:22)

I noticed that when defining a new asset the bucket is always imported with the same name. I think this may be the offending line.

[eladb]

You are right. It's a 🐛

The BucketRef is anchored at parent and should be anchored at this.

this.bucket = s3.BucketRef.import(parent, 'AssetBucket', {

should be changed to:

this.bucket = s3.BucketRef.import(this, 'AssetBucket', {

Should be an easy fix.

As a workaround, you can wrap your asset in a construct so it will be namespaced:

class MyAsset extends cdk.Construct {
  public readonly asset: Asset;
  constructor(parent: cdk.Construct, id: string, props: AssetProps) {
    super(parent, id);

    this.asset = new Asset(this, 'Asset', props);
  }
}

Then, you can use it:

const asset1 = new MyAsset(this, 'Asset1', { /* asset properties */ }).asset;
const asset2 = new MyAsset(this, 'Asset2', { /* asset properties */ }).asset;

[sentient-jbreindel]

Perfect thank you for the workaround!