[aws-eks] UnsupportedMediaType Error when creating KubernetesPatch for custom resource

[mattchrist]

When creating a KubernetesPatch construct to update the Gloo settings custom resource, I receive the following error:
Failed to create resource. Error: b'Error from server (UnsupportedMediaType): the body of the request was in an unknown format - accepted media types include: application/json-patch+json, application/merge-patch+json\n'

It appears that the default patch type of 'strategic' is not appropriate for patching this resource, and there's no mechanism available to specify a --type=merge or --type=json for the kubectl provider.

It's my understanding that custom resources in general do not support the default 'strategic' merge type.
https://kubernetes.io/docs/concepts/extend-kubernetes/api-extension/custom-resources/

Reproduction Steps

  const app = new App();
  const stack = new Stack(app, "stack", {});
  const cluster = new Cluster(stack, "deleteme");
  cluster.addChart("gloo", {
    chart: "gloo",
    repository: "https://storage.googleapis.com/solo-public-helm",
    version: "1.2.21",
    wait: true,
    values: {
      settings: {
        create: true
      }
    }
  });
  const glooPatch = new KubernetesPatch(stack, "enableConsulPatch", {
    applyPatch: {
      spec: {
        consul: {
          address: `127.0.0.1:8500`,
          serviceDiscovery: {}
        }
      }
    },
    restorePatch: { spec: { consul: {} } },
    cluster,
    resourceName: "Settings/default",
    resourceNamespace: `default`
  });

Error Log

Failed to create resource. Error: b'Error from server (UnsupportedMediaType): the body of the request was in an unknown format - accepted media types include: application/json-patch+json, application/merge-patch+json\n'

Environment

• CLI Version : 1.27.0
• Framework Version: 1.27.0
• OS : Mac OS 10.14.6
• Language : Typescript

Other

A PatchType field in the kubectl provider for patch resources would resolve this issue for me. I intend to submit a PR for this.

---

This is 🐛 Bug Report