Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a KMS alias to the new bootstrapping stack #6719

Closed
skinny85 opened this issue Mar 13, 2020 · 2 comments · Fixed by #9872
Closed

Add a KMS alias to the new bootstrapping stack #6719

skinny85 opened this issue Mar 13, 2020 · 2 comments · Fixed by #9872
Assignees
@skinny85
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 package/tools Related to AWS CDK Tools or CLI
Milestone
CLI

Comments

@skinny85
Copy link
Contributor

Now that we have a KMS key in the new bootstrapping stack, it would be great to also have a KMS alias there (so i't obvious in the console when looking at the key what is it for).
@skinny85 skinny85 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 13, 2020
@skinny85 skinny85 self-assigned this Mar 13, 2020
@skinny85 skinny85 added effort/small Small work item – less than a day of effort package/tools Related to AWS CDK Tools or CLI and removed needs-triage This issue or PR still needs to be triaged. labels Mar 13, 2020
@NetaNir
Copy link
Contributor

NetaNir commented Mar 13, 2020

I think it's also required for convention mode?

@skinny85
Copy link
Contributor Author

I think it's also required for convention mode?

Interestingly, no. That's because the Key is set on the Bucket level - which means any operations on it will implicitly use that Key (unless overridden when calling S3 APIs, but we know this won't happen in our assets upload). For that reason, you don't need to know the identifier of the Key (you do need permissions for it though).

@rix0rrr rix0rrr added the p1 label Aug 13, 2020
@rix0rrr rix0rrr added this to the [CLI] Soon milestone Aug 13, 2020
rix0rrr added a commit that referenced this issue Aug 20, 2020
@rix0rrr
fix(bootstrap): add alias for the asset key
f7c514e 
Add an alias (effectively, a display name) for the file asset bucket
encryption key, so it is easier to recognize in the console.

This change is otherwise not functional, the alias is not used to refer
to the key.

Fixes #6719.
@rix0rrr rix0rrr mentioned this issue Aug 20, 2020
Merged
@mergify mergify bot closed this as completed in #9872 Aug 20, 2020
mergify bot pushed a commit that referenced this issue Aug 20, 2020
@rix0rrr
fix(bootstrap): add alias for the asset key (#9872)
952e686 
Add an alias (effectively, a display name) for the file asset bucket
encryption key, so it is easier to recognize in the console.

This change is otherwise not functional, the alias is not used to refer
to the key.

Fixes #6719.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
CLI
Development

Successfully merging a pull request may close this issue.

fix(bootstrap): add alias for the asset key aws/aws-cdk
3 participants
@skinny85 @rix0rrr @NetaNir