-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iam): policy document from json #6486
Conversation
P.S. This is a draft PR. There are changes I expect to still make:
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Co-Authored-By: Elad Ben-Israel <[email protected]>
…cdk into feat/policy-document-parsing
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…cdk into feat/policy-document-parsing
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
If there are no issues with how I'm doing the Principals, I'll go ahead and implement similar for the NotPrincipals... |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
…cdk into feat/policy-document-parsing
Use a "raw" principal class that implements IPrincipal in order to simplify parsing of Principal and NotPrincipal in fromJson.
@mbonig I created a PR against your branch with my proposal. If you merge it to your branch it will be reflected here: https://github.com/mbonig/aws-cdk/pull/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mbonig waiting for your merge
…posal simplify principal parsing
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
In response to a recent comment regarding the importing of PolicyDocuments I thought I'd give it a stab with the .fromJSON static method on PolicyDocument and PolicyStatement.
A few notes:
.add
s, but I'm open to suggestions. Passing it in as a constructorprop
parameter doesn't seem like an option unless I'm misunderstanding something. I have not implemented the NotPrincipal logic (and won't) until I'm sure thisif
tree is the best way to get it done.Commit Message
feat(iam): policy document from json (#6486)
Allow creating PolicyDocuments from by parsing a JSON blob. Same for PolicyStatement.
End of Commit Message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license