adding additional tests

aws · Feb 27, 2020 · e31ea46 · e31ea46
1 parent b146cdf
commit e31ea46
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/packages/@aws-cdk/aws-iam/lib/policy-statement.ts b/packages/@aws-cdk/aws-iam/lib/policy-statement.ts
@@ -20,6 +20,9 @@ export class PolicyStatement {
       if (typeof (field) !== "string" && !Array.isArray(field)) {
         throw new Error("Fields must be either a string or an array of strings");
       }
+      if (Array.isArray(field) && !field.reduce((acc: boolean, f: any) => (acc && typeof (f) === "string"), true)) {
+        throw new Error("Fields must be either a string or an array of strings");
+      }
       return Array.isArray(field) ? field : [field];
     };
 

diff --git a/packages/@aws-cdk/aws-iam/test/policy-statement.test.ts b/packages/@aws-cdk/aws-iam/test/policy-statement.test.ts
@@ -237,6 +237,21 @@ describe('IAM policy statement', () => {
       expect(stack.resolve(doc)).toEqual(policyDocument);
     });
 
+    test('throws error with field data being object', () => {
+      expect(() => {
+        PolicyStatement.fromJson({
+          Action: {}
+        });
+      }).toThrow(/Fields must be either a string or an array of strings/);
+    });
+
+    test('throws error with field data being object', () => {
+      expect(() => {
+        PolicyStatement.fromJson({
+          Action: [{}]
+        });
+      }).toThrow(/Fields must be either a string or an array of strings/);
+    });
   });
 
 });