Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS EFS service L2 construct #6286

Closed
1 of 2 tasks
yashda opened this issue Feb 14, 2020 · 0 comments · Fixed by #6373
Closed
1 of 2 tasks

AWS EFS service L2 construct #6286

yashda opened this issue Feb 14, 2020 · 0 comments · Fixed by #6373
Assignees
@rix0rrr
Labels
@aws-cdk/aws-efs Related to Amazon Elastic File System effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@yashda
Copy link

yashda commented Feb 14, 2020

Use Case

We need an easier way to create a EFS and and its mount target. Also, it would be good if all the connections to this EFS can be handled in standard CDK way.

Proposed Solution

Write an L2 Construct which abstracts the creation of EFS and its mount targets. Also, it would implement the IConnectable interface so that it becomes easy to allow connections to/from other resources.

Other

  • 👋 I may be able to will implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@yashda yashda added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 14, 2020
@SomayaB SomayaB added the @aws-cdk/aws-efs Related to Amazon Elastic File System label Feb 17, 2020
@rix0rrr rix0rrr added the effort/large Large work item – several weeks of effort label Feb 18, 2020
yashda added a commit to yashda/aws-cdk that referenced this issue Feb 19, 2020
@yashda
feat(aws-efs): adding construct library for creating EFS
9b208a6 
* 100% unit test coverage.
* This was tested by creating an EFS using this construct in a cdk application.
  A instance was also created in this app, which successfully mounted it.

closes aws#6286
@yashda yashda mentioned this issue Feb 19, 2020
Merged
@SomayaB SomayaB added in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels Feb 20, 2020
yashda added a commit to yashda/aws-cdk that referenced this issue Feb 27, 2020
@yashda
feat(aws-efs): adding construct library for creating EFS
8916e92 
* 100% unit test coverage.
* This was tested by creating an EFS using this construct in a cdk application.
  A instance was also created in this app, which successfully mounted it.

closes aws#6286
@mergify mergify bot closed this as completed in #6373 Mar 5, 2020
mergify bot added a commit that referenced this issue Mar 5, 2020
@mergify @rix0rrr
feat(efs): create EFS file systems (#6373)
a0fb518 
* feat(aws-efs): adding construct library for creating EFS

* 100% unit test coverage.
* This was tested by creating an EFS using this construct in a cdk application.
  A instance was also created in this app, which successfully mounted it.

closes #6286

* addressing review comments

* setting correct ipaddress for mount targets

* feat(aws-efs): adding construct library for creating EFS

* 100% unit test coverage.
* This was tested by creating an EFS using this construct in a cdk application.
  A instance was also created in this app, which successfully mounted it.

closes #6286

* addressing review comments

* setting correct ipaddress for mount targets

* address review comments v2

* removing mount targets info

Co-authored-by: Rico Huijbers <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
eladb pushed a commit that referenced this issue Mar 9, 2020
@mergify @rix0rrr
feat(efs): create EFS file systems (#6373)
148ec0d 
* feat(aws-efs): adding construct library for creating EFS

* 100% unit test coverage.
* This was tested by creating an EFS using this construct in a cdk application.
  A instance was also created in this app, which successfully mounted it.

closes #6286

* addressing review comments

* setting correct ipaddress for mount targets

* feat(aws-efs): adding construct library for creating EFS

* 100% unit test coverage.
* This was tested by creating an EFS using this construct in a cdk application.
  A instance was also created in this app, which successfully mounted it.

closes #6286

* addressing review comments

* setting correct ipaddress for mount targets

* address review comments v2

* removing mount targets info

Co-authored-by: Rico Huijbers <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
horsmand pushed a commit to horsmand/aws-cdk that referenced this issue Mar 9, 2020
@mergify @rix0rrr @horsmand
feat(efs): create EFS file systems (aws#6373)
b9b4ca3 
* feat(aws-efs): adding construct library for creating EFS

* 100% unit test coverage.
* This was tested by creating an EFS using this construct in a cdk application.
  A instance was also created in this app, which successfully mounted it.

closes aws#6286

* addressing review comments

* setting correct ipaddress for mount targets

* feat(aws-efs): adding construct library for creating EFS

* 100% unit test coverage.
* This was tested by creating an EFS using this construct in a cdk application.
  A instance was also created in this app, which successfully mounted it.

closes aws#6286

* addressing review comments

* setting correct ipaddress for mount targets

* address review comments v2

* removing mount targets info

Co-authored-by: Rico Huijbers <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@snyk-bot snyk-bot mentioned this issue Apr 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-efs Related to Amazon Elastic File System effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
3 participants
@rix0rrr @SomayaB @yashda