Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(s3-deployment): passing any system metadata causes lambda to fail on "Unknown options:" when invoking aws cli. #6086

Merged
merged 22 commits into from
Feb 6, 2020
Merged

fix(s3-deployment): passing any system metadata causes lambda to fail on "Unknown options:" when invoking aws cli. #6086

merged 22 commits into from
Feb 6, 2020

Conversation

AlexCheema
Copy link
Contributor

Fixes #4665

The AWS CLI list of commands generated when using system-defined metadata bundled together pairs of arguments, which caused the CLI to give e.g. Unknown options: --cache-control 'max-age=600' as an error. The fix is to ensure that each argument is a separate string in the list of AWS CLI commands.

Tests have been added for checking individual aws commands elementwise.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Alex Cheema and others added 12 commits October 26, 2019 16:09
fix(aws-s3-deployment): fix passing system metadata to deployment
b2f9d38
@AlexCheema
Merge branch 'master' into alexcheema/s3-deployment-metadata-fix
f45cf70
@AlexCheema
Merge branch 'master' into alexcheema/s3-deployment-metadata-fix
b6e464d
@AlexCheema
Merge branch 'master' into alexcheema/s3-deployment-metadata-fix
dd06a90
@AlexCheema
Merge branch 'master' into alexcheema/s3-deployment-metadata-fix
5f6652e
@AlexCheema
Merge branch 'master' into alexcheema/s3-deployment-metadata-fix
b6571dc
@AlexCheema
Merge branch 'master' into alexcheema/s3-deployment-metadata-fix
cc46a32
Merge branch 'master' into alexcheema/s3-deployment-metadata-fix
2067818
Merge branch 'master' into alexcheema/s3-deployment-metadata-fix
506898f
@AlexCheema
Merge remote-tracking branch 'origin/master' into alexcheema/s3-deplo…
f998606 
…yment-metadata-fix
@AlexCheema
fix(s3-deployment): fix custom metadata, tests for checking individua…
0afc37b 
…l elements in aws commands
@AlexCheema
Merge remote-tracking branch 'origin/master' into alexcheema/s3-deplo…
1f28411 
…yment-metadata-fix
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@eladb eladb changed the title fix(s3-deployment): passing system metadata to deployment fix(s3-deployment): unable to set cache control Feb 4, 2020
eladb
eladb previously approved these changes Feb 4, 2020
View reviewed changes
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot dismissed eladb’s stale review February 4, 2020 10:15

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@iliapolo iliapolo self-assigned this Feb 4, 2020
@AlexCheema @iliapolo
Apply suggestions from code review
3753c10 
fix(s3-deployment): remove unnecessary fstring

Co-Authored-By: Eli Polonsky <[email protected]>
@mergify mergify bot dismissed iliapolo’s stale review February 4, 2020 17:23

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AlexCheema
Copy link
Contributor Author

@eladb some minor changes after your previous review

@AlexCheema AlexCheema requested a review from eladb February 5, 2020 14:19
@AlexCheema AlexCheema changed the title fix(s3-deployment): unable to set cache control fix(s3-deployment): passing system metadata to deployment Feb 5, 2020
@AlexCheema AlexCheema changed the title fix(s3-deployment): passing system metadata to deployment fix(s3-deployment): passing any system metadata causes lambda to fail on "Unknown options:" when invoking aws cli. Feb 6, 2020
@iliapolo iliapolo mentioned this pull request Feb 6, 2020
Closed
@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit b30add8 into aws:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliapolo iliapolo iliapolo approved these changes

@eladb eladb Awaiting requested review from eladb

Assignees

@iliapolo iliapolo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BucketDeployment: unable to set cacheControl
4 participants
@AlexCheema @aws-cdk-automation @eladb @iliapolo