BucketDeployment: unable to set cacheControl

[sbstjn]

Using cacheControl for BucketDeployment in @aws-cdk/aws-s3-deployment does not work.

Reproduction Steps

new BucketDeployment(this, 'deployment', {
  sources: [Source.asset(path.resolve(__dirname, '../build'))],
  destinationBucket: assets,
  distribution: cdn.distribution,
  cacheControl: [CacheControl.fromString(`max-age=600`)]
})

new BucketDeployment(this, 'deployment', {
  sources: [Source.asset(path.resolve(__dirname, '../build'))],
  destinationBucket: assets,
  distribution: cdn.distribution,
  cacheControl: [CacheControl.maxAge(Duration.minutes(10))]
})

Error Log

Lambda error log for /aws/lambda/…CustomCDKBucketDeployment…:

aws s3 sync --delete /tmp/…/contents s3://foobar/ --cache-control 'max-age=600' --metadata-directive REPLACE

Unknown options: --cache-control 'max-age=600'

Environment

• CLI Version : 1.14.0
• Framework Version: @aws-cdk/[email protected]
• Language : typescript

---

This is 🐛 Bug Report

[eladb]

@AlexCheema can you take a look please?

[iliapolo]

This problem is actually not strictly related to cache-control. It will happen for every property that eventually translates to SystemMetadata. The fix proposed in the mentioned PR address that problem as a whole.