Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolkit: stack update failure should show StackStatusReason #604

Closed
mipearson opened this issue Aug 19, 2018 · 1 comment · Fixed by #609
Closed

Toolkit: stack update failure should show StackStatusReason #604

mipearson opened this issue Aug 19, 2018 · 1 comment · Fixed by #609
Labels
good first issue Related to contributions. See CONTRIBUTING.md

Comments

@mipearson
Copy link

mipearson commented Aug 19, 2018 •
edited
Loading

Deleting the stack vpc-demo which exports a vpc reference currently used by other stacks fails with no message other than UPDATE_COMPLETE:

 ⏳  Starting destruction of stack vpc-demo...
 ❌  Destruction failed: vpc-demo Error: Failed to destroy vpc-demo (current state: UPDATE_COMPLETE)!
    at Object.destroyStack (/Users/mp/.nvm/versions/node/v10.7.0/lib/node_modules/aws-cdk/lib/api/deploy-stack.ts:152:15)
    at process._tickCallback (internal/process/next_tick.js:68:7)
Failed to destroy vpc-demo (current state: UPDATE_COMPLETE)!

I would expect at best it to tell me which stacks are using its outputs or at worst the fact that it can't be deleted because of that.

Looking at the output of list-stacks via the AWS CLI shows that this error is present and should be returned to the user:

            "StackStatus": "UPDATE_COMPLETE",
            "StackStatusReason": "Export vpc-demo:DemoVPCPublicSubnetIDs0C2D9BEE cannot be deleted as it is in use by cdk-vpc-to-cfn-elb-demo and elb-cfn-demo"
        },
@rix0rrr rix0rrr changed the title Deletion of stack that other stack depends on does not provide useful diagnostics Toolkit: stack update failure should show StackStatusReason Aug 20, 2018
@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 20, 2018

Good call.

@rix0rrr rix0rrr added the good first issue Related to contributions. See CONTRIBUTING.md label Aug 20, 2018
rix0rrr pushed a commit that referenced this issue Aug 20, 2018
feat(aws-cdk): display status reason on failure
2ae3035 
Make the toolkit show the StackStatusReason if deploying
or destroying failed.

Fixes #604.
@rix0rrr rix0rrr mentioned this issue Aug 20, 2018
Merged
rix0rrr added a commit that referenced this issue Aug 22, 2018
@rix0rrr
feat(aws-cdk): display status reason on failure (#609)
128d55d 
Make the toolkit show the StackStatusReason if deploying
or destroying failed.

Fixes #604.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Related to contributions. See CONTRIBUTING.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aws-cdk): display status reason on failure aws/aws-cdk
2 participants
@mipearson @rix0rrr