-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeBuild SourceVersion #5777
Comments
Hey @knorms101 , thanks for opening the issue, but I think I would solve it differently :). I think we should add an optional property Would you be interested in submitting us a PR with this feature @knorms101 ? Thanks, |
Hello @skinny85, I'm happy to submit a PR for this! And I prefer your solution, so I'll plan on submitting a PR with that implementation later this week or early next week. Thanks, |
Thanks for opening a PR @knorms101, much appreciated! 👍 |
* feat(aws-codebuild): allow github sourceversion branch Addresses issue #5777.Users may want to specify which github branch a codebuild should use as its source. Currently the branch always defaults to 'master', but users may want to test features in development on other branches * add required documentation * add sourceVersion to all CodeBuild sources. Add secondarySourceVersions option * unify version on GitSource to branch or ref. fix indentation. remove unused property. only render secondary sources versions when present. * update s3 name to version * remove duplication Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This was done in #5890 . Thanks again for the contribution @knorms101 ! |
I would like to be able to specify the
sourceVersion
associated with a CodeBuild project.Use Case
To specify which Github branch CodeBuild should use for its source version.
Proposed Solution
Would need to add an optional
sourceVersion
property that errors if asource
isn't specified.https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-codebuild/lib/project.ts#L521
Other
This is a 🚀 Feature Request
The text was updated successfully, but these errors were encountered: