Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics for RDS Cluster #5212

Closed
vertti opened this issue Nov 27, 2019 · 0 comments · Fixed by #10162
Closed

Metrics for RDS Cluster #5212

vertti opened this issue Nov 27, 2019 · 0 comments · Fixed by #10162
Assignees
@njlynch
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2
Milestone
[GA] RDS

Comments

@vertti
Copy link

vertti commented Nov 27, 2019

Examples for convenient setting of cloudwatch alarms are documented only for RDS Instance, not for a cluster:

https://docs.aws.amazon.com/cdk/api/latest/docs/aws-rds-readme.html#metrics

I would expect exactly same metrics to be available. No metric fields are found from the DatabaseCluster instance and there doesn't seem to be a way to get the instances from the cluster object. Like with #5195 , the ClusterDatabase seems a second class citizen compared to DatabaseInstance which seems really odd.

Environment

  • CLI Version : 1.18.0
  • Framework Version: 1.18.0
  • OS : Ubuntu
  • Language : Typescript

This is 🐛 Bug Report
@vertti vertti added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 27, 2019
@skinny85 skinny85 self-assigned this Nov 27, 2019
@skinny85 skinny85 added gap @aws-cdk/aws-rds Related to Amazon Relational Database and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 27, 2019
@rix0rrr rix0rrr added the good first issue Related to contributions. See CONTRIBUTING.md label Dec 2, 2019
@SomayaB SomayaB added feature-request A feature should be added or improved. and removed gap labels Dec 30, 2019
@skinny85 skinny85 added the effort/medium Medium work item – several days of effort label Feb 6, 2020
@skinny85 skinny85 assigned nija-at and unassigned skinny85 Feb 6, 2020
@skinny85 skinny85 added this to the RDS to 'stable' milestone Jul 8, 2020
@nija-at nija-at assigned skinny85 and unassigned nija-at Jul 14, 2020
@skinny85 skinny85 added the p2 label Aug 19, 2020
@njlynch njlynch assigned njlynch and unassigned skinny85 Sep 3, 2020
njlynch added a commit that referenced this issue Sep 3, 2020
@njlynch
feat(rds): metrics for clusters
b68c521 
Introduces metrics for clusters, with both common metrics getting `metricXxx`
methods and the general `metric()` method for custom metrics.

I opted for covering all metrics that are available for both Aurora MySQL and
Aurora PostgreSQL by default.
See https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/Aurora.Monitoring.html

This change also required tweaking the augmentation generation in two ways:
1. Supporting the interface and base class being in separate files.
2. Supporting multiple augmentated classes in the same module.

fixes #5212
@njlynch njlynch mentioned this issue Sep 3, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Sep 3, 2020
@mergify mergify bot closed this as completed in #10162 Sep 7, 2020
mergify bot pushed a commit that referenced this issue Sep 7, 2020
@njlynch
feat(rds): metrics for clusters (#10162)
49f6034 
Introduces metrics for clusters, with both common metrics getting `metricXxx`
methods and the general `metric()` method for custom metrics.

I opted for covering all metrics that are available for both Aurora MySQL and
Aurora PostgreSQL by default.
See https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/Aurora.Monitoring.html

This change also required tweaking the augmentation generation in two ways:
1. Supporting the interface and base class being in separate files.
2. Supporting multiple augmentated classes in the same module.

fixes #5212


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
[GA] RDS
Development

Successfully merging a pull request may close this issue.

feat(rds): metrics for clusters aws/aws-cdk
6 participants
@skinny85 @rix0rrr @vertti @njlynch @nija-at @SomayaB