Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for task definition family name for queue processing ECS services #4507

Closed
1 of 2 tasks
pkspks opened this issue Oct 15, 2019 · 1 comment · Fixed by #4508
Closed
1 of 2 tasks

Support for task definition family name for queue processing ECS services #4507

pkspks opened this issue Oct 15, 2019 · 1 comment · Fixed by #4508
Assignees
@piradeepk
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@pkspks
Copy link

pkspks commented Oct 15, 2019 •
edited
Loading

QueueProcessingEc2Service and QueueProcessingFargateService don't support providing service name when constructing the services.

Use Case

Task family names group versions of task definitions.

Proposed Solution

Add optional taskDefinitionFamily: String in QueueProcessingServiceBaseProps.ts and use it when creating services in QueueProcessingEc2Service.ts and QueueProcessingFargateService.ts
This approach does not break existing code.

Not sure about the direction in which we want this to head but another approach may be to introduce taskImageOptions: QueueProcessingTaskImageOptions ala NetworkLoadBalancedTaskImageOptions and ApplicationLoadBalancedTaskImageOptions and move task and image related attributes from QueueProcessingServiceBaseProps to QueueProcessingTaskImageOptions.
This will affect attributes like image, logDriver, environment, secrets but will move QueueProcessingServiceBase closer to other implementations.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@pkspks pkspks added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 15, 2019
pkspks pushed a commit to pkspks/aws-cdk that referenced this issue Oct 15, 2019
@dependabot-preview
feat(ecs-patterns): add support for specifying ECS task defnition fam…
84a3d78 
…ily name in queue processing ECS service constructs (aws#4507)
@pkspks pkspks mentioned this issue Oct 15, 2019
Merged
pkspks pushed a commit to pkspks/aws-cdk that referenced this issue Oct 15, 2019
@dependabot-preview
feat(ecs-patterns): add support for specifying ECS task definition fa…
aadc3e3 
…mily name in queue processing ECS service constructs (aws#4507)
@piradeepk piradeepk assigned piradeepk and unassigned piradeepk Oct 15, 2019
@SomayaB SomayaB added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Oct 15, 2019
@SomayaB
Copy link
Contributor

SomayaB commented Oct 15, 2019 •
edited
Loading

Thanks for working on these @pkspks, we appreciate it! 👍

@SomayaB SomayaB added in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 15, 2019
@piradeepk piradeepk self-assigned this Oct 15, 2019
pkspks pushed a commit to pkspks/aws-cdk that referenced this issue Oct 15, 2019
@dependabot-preview
feat(ecs-patterns): add support for specifying ECS task definition fa…
36894c2 
…mily name in queue processing ECS service constructs (aws#4507)
@mergify mergify bot closed this as completed in #4508 Oct 18, 2019
mergify bot pushed a commit that referenced this issue Oct 18, 2019
@mergify
feat(ecs-patterns): add family name to queue processing service prope…
b0874bb 
…rties (#4508)

* feat(ecs-patterns): add support for specifying ECS task definition family name in queue processing ECS service constructs (#4507)

* feat(ecs-patterns) renaming taskDefinitionFamily to family to be more inline with other taskdef properties

* feat(ecs-patterns) adding unit tests to check if family name is autogenerated if not passed in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piradeepk piradeepk

Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs-patterns): add family name to queue processing service properties pkspks/aws-cdk
4 participants
@pkspks @SomayaB @SoManyHs @piradeepk