Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudwatch): don't ignore 'stacked' property in GraphWidget class #3796

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

loganek
Copy link
Contributor

@loganek loganek commented Aug 26, 2019

Stacked property was available and documented in the GraphWidget class, but it wasn't used for generating the cloudformation template. This change fixes the problem.

Fixes #2103


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@eladb eladb self-assigned this Aug 27, 2019
packages/@aws-cdk/aws-cloudwatch/lib/graph.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cloudwatch/test/test.dashboard.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cloudwatch/test/test.dashboard.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cloudwatch/test/test.graphs.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cloudwatch/test/test.graphs.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cloudwatch/test/test.graphs.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cloudwatch/test/test.graphs.ts Outdated Show resolved Hide resolved
@eladb eladb merged commit 527b362 into aws:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-cloudwatch] fix: GraphWidgetProps contains "stacked" but it is not forwarded to the output
2 participants