Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-cloudwatch] fix: GraphWidgetProps contains "stacked" but it is not forwarded to the output #2103

Closed
ZeldoKavira opened this issue Mar 27, 2019 · 0 comments · Fixed by #3796
Closed

[aws-cloudwatch] fix: GraphWidgetProps contains "stacked" but it is not forwarded to the output #2103

ZeldoKavira opened this issue Mar 27, 2019 · 0 comments · Fixed by #3796

Comments

@ZeldoKavira
Copy link
Contributor

The stacked flag is in GraphWidgetProps but is not forwarded to the final object in ToJson();

https://github.com/awslabs/aws-cdk/blob/c968588fa18aadae65027628cbc6b4274247426f/packages/%40aws-cdk/aws-cloudwatch/lib/graph.ts#L144
loganek added a commit to loganek/aws-cdk that referenced this issue Aug 26, 2019
@loganek
fix(cloudwatch): don't ignore 'stacked' property in GraphWidget class (…
3a0992f 
…aws#2103)
@loganek loganek mentioned this issue Aug 26, 2019
Merged
loganek added a commit to loganek/aws-cdk that referenced this issue Aug 27, 2019
@loganek
fix(cloudwatch): don't ignore 'stacked' property in GraphWidget class (…
7865a72 
…aws#2103)
eladb pushed a commit that referenced this issue Aug 28, 2019
@loganek
fix(cloudwatch): don't ignore 'stacked' property in GraphWidget class (…
527b362 
…#2103) (#3796)

Stacked property was available and documented in the GraphWidget class, but it wasn't used for generating the cloudformation template. This change fixes the problem.

Fixes #2103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cloudwatch): don't ignore 'stacked' property in GraphWidget class loganek/aws-cdk
1 participant
@ZeldoKavira