Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target group configuration could include better validation #3703

Closed
markusl opened this issue Aug 19, 2019 · 3 comments
Closed

Target group configuration could include better validation #3703

markusl opened this issue Aug 19, 2019 · 3 comments
Labels
@aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@markusl
Copy link
Contributor

markusl commented Aug 19, 2019

🚀 Feature Request

General Information

If user accidentally writes the following code, it will be rejected when deploying:

target.configureHealthCheck({
        interval: cdk.Duration.seconds(60),
        timeout: cdk.Duration.seconds(60),
        healthyThresholdCount: 2,
        unhealthyThresholdCount: 5,
      })

Health check interval must be greater than the timeout. (Service: AmazonElasticLoadBalancingV2; Status Code: 400; Error Code: ValidationError; Request

Proposed Solution

This kind of validations could be done already in CDK to speed up the development cycle.

Environment

  • CDK CLI Version: 1.4.0
@markusl markusl added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 19, 2019
@rix0rrr rix0rrr added @aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing and removed needs-triage This issue or PR still needs to be triaged. labels Aug 28, 2019
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md labels Jan 23, 2020
@rix0rrr rix0rrr added the p2 label Aug 12, 2020
@SomayaB SomayaB assigned njlynch and unassigned rix0rrr Aug 20, 2020
mergify bot pushed a commit that referenced this issue Sep 10, 2020
…rget group (#3703) (#10205)


Add the following Health Check validations for Network Target Group:
 - `healthyThresholdCount` and `unhealthyThresholdCount` must the same
 - `healthyThresholdCount` and `unhealthyThresholdCount` must be between 2 and 10

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot pushed a commit that referenced this issue Aug 27, 2021
…ate interval versus timeout (#16107)

fix: Add validation to target group health check creation. Fixes issue #3703.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@bl-ue
Copy link
Contributor

bl-ue commented Sep 1, 2021

Shouldn't this be closed now that #16107 has been merged?

@markusl
Copy link
Contributor Author

markusl commented Sep 1, 2021

Thanks for noticing. I'll assume this has been implemented :)

@markusl markusl closed this as completed Sep 1, 2021
@github-actions
Copy link

github-actions bot commented Sep 1, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Sep 6, 2021
…ate interval versus timeout (aws#16107)

fix: Add validation to target group health check creation. Fixes issue aws#3703.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this issue Sep 7, 2021
…ate interval versus timeout (aws#16107)

fix: Add validation to target group health check creation. Fixes issue aws#3703.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Development

No branches or pull requests

4 participants