Assert: Incorrect matches with MatchStyle.SUPERSET

[nmussy]

Note: for support questions, please first reference our documentation, then use Stackoverflow. This repository's issues are intended for feature requests and bug reports.

• I'm submitting a ...

  • 🪲 bug report
  • 🚀 feature request
  • 📚 construct library gap
  • ☎️ security issue or vulnerability => Please see policy
  • ❓ support request => Please see note at the top of this template.

• What is the current behavior?
  If the current behavior is a 🪲bug🪲: Please provide the steps to reproduce
  Given the following test:
  

  aws-cdk/packages/@aws-cdk/aws-ecs/test/test.ecs-cluster.ts

  Lines 300 to 305 in 5c01a39

  	test.deepEqual(template.Parameters, {
  	"SsmParameterValueawsserviceecsoptimizedamiwindowsserver2019englishfullrecommendedimageidC96584B6F00A464EAD1953AFF4B05118Parameter": {
  	"Type": "AWS::SSM::Parameter::Value<String>",
  	"Default": "/aws/service/ecs/optimized-ami/windows_server/2019/english/full/recommended/image_id"
  	}
  	});

Both of these tests also pass:

// should match, does match
expect(stack).toMatch({
  "Parameters": {
    "SsmParameterValueawsserviceecsoptimizedamiwindowsserver2019englishfullrecommendedimageidC96584B6F00A464EAD1953AFF4B05118Parameter": {
      "Type": "AWS::SSM::Parameter::Value<String>",
      "Default": "/aws/service/ecs/optimized-ami/windows_server/2019/english/full/recommended/image_id"
    }
  }
}, MatchStyle.SUPERSET);

// shouldn't match, does match
expect(stack).toMatch({
  "Parameters": {
    "SsmParameterValueawsserviceecsoptimizedamiwindowsserver2019englishfullrecommendedimageidC96584B6F00A464EAD1953AFF4B05118Parameter": {
      "Type": "AWS::SSM::Parameter::Value<String>",
      "Default": "incorrect"
    }
  }
}, MatchStyle.SUPERSET);

• What is the expected behavior (or behavior of feature suggested)?
  The second added assertions should fail

• What is the motivation / use case for changing the behavior or adding this feature?
  Contributor and maintainer QoL, doesn't require synthesizing an app

• Please tell us about your environment:

  • CDK CLI Version: 1.1.0
  • Module Version: 1.1.0
  • OS: all
  • Language: all

• Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, gitter, etc)
  I haven't really looked into it yet, but any insight would be appreciated.