Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include All Canned ACLs for S3 Buckets #3383

Closed
1 of 5 tasks
ialford opened this issue Jul 22, 2019 · 0 comments · Fixed by #3391
Closed
1 of 5 tasks

Include All Canned ACLs for S3 Buckets #3383

ialford opened this issue Jul 22, 2019 · 0 comments · Fixed by #3391
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@ialford
Copy link
Contributor

ialford commented Jul 22, 2019

Note: for support questions, please first reference our documentation, then use Stackoverflow. This repository's issues are intended for feature requests and bug reports.

  • I'm submitting a ...

    • 🪲 bug report
    • 🚀 feature request
    • 📚 construct library gap
    • ☎️ security issue or vulnerability => Please see policy
    • ❓ support request => Please see note at the top of this template.

  • What is the current behavior?
    If the current behavior is a 🪲bug🪲: Please provide the steps to reproduce

When creating an S3 bucket via the CDK, some of the canned ACLs that are exposed by AWS are not available, even though they are available via CloudFormation.

  • What is the expected behavior (or behavior of feature suggested)?

I would expect all Canned ACLs would be available via the CDK when creating a bucket.

  • What is the motivation / use case for changing the behavior or adding this feature?

Creating an S3 bucket specifically for logging is more problematic than it is in CloudFormation.

  • Please tell us about your environment:

    • CDK CLI Version: ℹ️ CDK Version: 1.0.0 (build d89592e)
    • Module Version: @aws-cdk/[email protected]
    • OS: OSX Mojave 10/14/5
    • Language: TypeScript

  • Other information
    I would like to see this implemented across all languages - I believe it is a useful addition as the Canned ACLs are already exposed in CloudFormation.
@ialford ialford added the needs-triage This issue or PR still needs to be triaged. label Jul 22, 2019
@nmussy nmussy mentioned this issue Jul 23, 2019
Merged
@RomainMuller RomainMuller added the feature-request A feature should be added or improved. label Jul 23, 2019
eladb pushed a commit that referenced this issue Jul 23, 2019
feat(s3): bucket access control (#3391)
820575b 
Implements missing Bucket [AccessControl](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-s3-bucket.html#cfn-s3-bucket-accesscontrol) property
The documentation was for the canned ACLs was retrieved from [the developer guide](https://docs.aws.amazon.com/AmazonS3/latest/dev/acl-overview.html#canned-acl).

Fixes #3383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(s3): bucket access control logicgram/aws-cdk
2 participants
@RomainMuller @ialford