fix(ecs): update driverOpts type definition from array to map

[nmussy]

BREAKING CHANGE @aws-cdk/aws-ecs.DockerVolumeConfiguration.driverOpts: The type was incorrectly defined as string[], now fixed to {[key: string]: string}.

Fixes #3341

---

Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[nmussy]

I don't understand why the build fails, could someone help me out? Thanks in advance.

[eladb]

I suspect this is a breaking change although seems like the original type was actually a bug. @SoManyHs what do you think?

[piradeepk]

I suspect this is a breaking change although seems like the original type was actually a bug. @SoManyHs what do you think?

@eladb Yes to both, the original type was incorrect, and it should have been a map not an array. @nmussy Thanks for taking the time to fix the issue!

[piradeepk]

LGTM! Thanks for fixing the issue!

[nmussy]

Thanks for the review! I still don't know why the build fails though?

[piradeepk]

I believe it's because there are changes that break the current behaviour (which is expected). @eladb how do you want to proceed?

[eladb]

Since this is an experimental module, you can add an exception. See aecaa5d

Make sure to ibdicate this in the commit message per convention.

[nmussy]

Should be good. @eladb Should we tag v2 issue, or at least add a review allowed-breaking-changes.txt step?

[piradeepk]

Since this is an experimental module, you can add an exception. See aecaa5d

Make sure to ibdicate this in the commit message per convention.

@eladb not sure if you're thinking about aws-ecs-patterns but these changes are for the aws-ecs module which should be stable not experimental.

[nmussy]

I ran scripts/check-api-compatibility.sh locally and didn't get any errors. I guess I didn't build it properly. Do I have to add every method listed in the error to the breaking-changes.txt?

aws-cdk/allowed-breaking-changes.txt

Line 1 in 3c83197

changed-type:@aws-cdk/aws-ecs.DockerVolumeConfiguration.driverOpts